#3637·sure

DS Drift Patrol — Week of 2026-09-14

Author: sure-designCreated Sep 19, 2026Updated Sep 19, 2026
Labelsds-drift

DS Drift Patrol — main branch findings (commits since 2026-09-12)

Rule 1 — Bypassing DS components

  • 629bf2a (jaysbeekay) app/views/coinspot_items/_coinspot_item.html.erb:9 and app/views/settings/providers/_coinspot_panel.html.erb:31 — new CoinSpot provider views hand-roll a bg-surface-inset rounded-full icon badge instead of reusing ProviderLogo, the shared component introduced earlier the same day in #3527 and already adopted by every other provider card/panel.
  • 985b512 (janbuchar) app/views/fio_items/_fio_item.html.erb:10-11 and app/views/settings/providers/_fio_panel.html.erb:25-26 — new Fio provider views hand-roll a bg-surface rounded-full initials badge (item.name.first.upcase) instead of ProviderLogo, which had already replaced this exact pattern for every other provider by the time this PR merged (3 days after #3527).
  • 44bbfb2 (ampersandru) app/views/pages/dashboard.html.erb:~85 — the dashboard balance-sheet "Expand all" toggle is a hand-rolled <button> with duplicated ARIA/icon-swap logic, even though this same commit introduces DS::ExpandToggle for the identical sidebar behavior. The balance-sheet copy doesn't reuse the new component.