Transmission runs "finish" script when none is specified
What is the issue?
Transmission version: Transmission 4.1.0 OS Platform: Linux (Debian 13)
Description of problem: If, in the past, the Transmission client (transmission-cli) has specified a "finish" script on the command line, Transmission will always run the same "finish" script after downloading a torrent, whether it has been requested or not.
Expected behaviour: To enable a "finish" script to run, the user should need to specify it on the command line with the "-f" or "--finish" flags, each time the script needs to be run.
Encountered behaviour: Once the "--finish" flag has been used once, Transmission remembers the script specified and always runs it when completing a torrent download in the future, even if Transmission has been terminated and a new Transmission instance launched.
Additional details: When the "--finish" flag has been included with the transmission-cli command line, the following variables are set in the Transmission settings.json file:
"script-torrent-done-enabled": true "script-torrent-done-filename": "/path/to/script-to-run"
This causes any future instances of Transmission to enable and run this same script any time a new copy of Transmission is launched. This is unexpected since "--finish" does not need to be specified on the command line to trigger the script.
This is, in my opinion, also a problem because there is no command line option to disable the "finish" script, the user needs to open the settings.json file to disable the script-torrent-done-enabled variable manually.
Recommended fixes:
Transmission should "forget" any "--finish" directive once its process terminates. The "finish" script should not be saved and run by later instances as the script might be destructive.
Alternatively, there should be a "--disable-finish" (or similar) command line option to turn off the script for when it is not needed.
Which application of Transmission?
transmission-daemon
Which version of Transmission?
4.1.0
Source: transmission/transmission