GitHub release - Source code assets are missing /libs/hbb_common submodule
Describe the bug
GitHub releases of source code tarballs (both .zip. and .tar.gz) are missing the /libs/hbb_common submodule.
The folder is present, but is empty.
For example:
Source code (tar.gz) for version 1.1.16.
This has been happening ever since version 1.1.13 (version 1.1.12 is the last one that contains the submodule)
Describe the environment Source code releases from versions 1.1.13 (including) going forward.
How to Reproduce the bug Steps to reproduce the behavior:
- Go to releases page
- Download a source code (
.zipor.tar.gz) - Unpack
- Observe contents of
/libs/hbb_commondirectory is empty - [optional] Attempt to build the application
error: failed to load manifest for workspace member `rustdesk-server-1.1.16/libs/hbb_common`Expected behavior Source release should contain every submodule required to build the application.
Additional context I believe it is caused by GitHub not including git submodules in automatically generated source code tarballs. Since 1.1.13 (specifically Commit 7a509f6) the hbb_common lib is added as a submodule.
Possible solution would be to build the tarballs manually inside the build workflow.
References:
Source: rustdesk/rustdesk-server