Instance folder not deduplicated if using multiple instance folders

Operating System

Linux (Fedora

Version of Prism Launcher

Prism Launcher 12.0.0 (develop)

Version of Qt

6.11.2

Description of bug

Say I have two instance folders, a as the default instance folder and b as an additional one. If I create an instance named CoolInstance in a, then another instance named CoolInstance in b only the first instance will be shown (you can check by having different icons). This is because the usual folder name deduplication mechanism isn't working - both folders are named CoolInstance rather than CoolInstance for the first and CoolInstance(1) for the second.

Steps to reproduce

• Open settings
• Add an extra instance folder
• Create two instances with the same name - one in the default folder and another in the extra folder
• Observe only one instance being present in the UI and both folders having the same name

Other information

Presumably caused by this, which is completely generic and doesn't account for multiple instance dirs

https://github.com/PrismLauncher/PrismLauncher/blob/719881f77f09cce86ea4bef0ecfec6338309777f/launcher/FileSystem.cpp#L965-L976

This issue is unique

• I have searched the issue tracker and did not find an issue describing my bug.