Analysis runs on a body-stripped AST: phantom return.missing / expr.resultUnused since 2.2.10

parameters:
    level: 7
    paths:
        - src

<?php

namespace Renatio\SeoManager\Classes\Analysis;

class Result
{
    public const STATUS_OK = 'ok';

    public const STATUS_WARNING = 'warning';

    public const STATUS_PROBLEM = 'problem';

    /**
     * A check that has nothing to look at - no keyword chosen, no body to read - is not a failure.
     * It leaves the score entirely, or every page without a keyword would show a red 30.
     */
    public const STATUS_SKIPPED = 'skipped';

    public function __construct(
        protected string $key,
        protected string $status,
        protected string $message,
        protected int $weight = 0,
    ) {
    }

    public function key(): string
    {
        return $this->key;
    }

    public function status(): string
    {
        return $this->status;
    }

    public function message(): string
    {
        return $this->message;
    }

    public function weight(): int
    {
        return $this->weight;
    }

    public function label(): string
    {
        return __('renatio.seomanager::lang.analysis.' . $this->key);
    }

    public function counts(): bool
    {
        return $this->status !== self::STATUS_SKIPPED;
    }

    public function isPassed(): bool
    {
        return $this->status === self::STATUS_OK;
    }
}

<?php

namespace Renatio\SeoManager\Classes\Analysis;

/**
 * What the analysis found, and the one number people compare against other SEO plugins. The number
 * is a share of the weight that applied: a check with nothing to look at leaves the denominator, so
 * a page that simply has no keyword yet is not reported as a failing one.
 */
class Report
{
    public const BAND_GOOD = 'good';

    public const BAND_FAIR = 'fair';

    public const BAND_POOR = 'poor';

    /** Nothing was measured, so nothing is being said about the page. */
    public const BAND_NONE = 'none';

    protected const GOOD_FROM = 80;

    protected const FAIR_FROM = 50;

    /** A passed check counts whole, a warning half: it is a page that works but could work better. */
    protected const WARNING_SHARE = 0.5;

    /**
     * @param  array<int, Result>  $results
     */
    public function __construct(protected array $results)
    {
    }

    /**
     * @return array<int, Result>
     */
    public function results(): array
    {
        return $this->results;
    }

    /**
     * @return array<int, Result>
     */
    public function applied(): array
    {
        return array_values(array_filter($this->results, fn (Result $result) => $result->counts()));
    }

    public function score(): ?int
    {
        $total = 0;
        $earned = 0.0;

        foreach ($this->applied() as $result) {
            $total += $result->weight();
            $earned += match ($result->status()) {
                Result::STATUS_OK => $result->weight(),
                Result::STATUS_WARNING => $result->weight() * self::WARNING_SHARE,
                default => 0,
            };
        }

        return $total === 0 ? null : (int) round($earned / $total * 100);
    }

    public function band(): string
    {
        $score = $this->score();

        if ($score === null) {
            return self::BAND_NONE;
        }

        return match (true) {
            $score >= self::GOOD_FROM => self::BAND_GOOD,
            $score >= self::FAIR_FROM => self::BAND_FAIR,
            default => self::BAND_POOR,
        };
    }

    public function passed(): int
    {
        return count(array_filter($this->applied(), fn (Result $result) => $result->isPassed()));
    }
}

$ phpstan analyse -c phpstan.neon
 ------ ---------------------------------------------------------------------------
  Line   src/Result.php
 ------ ---------------------------------------------------------------------------
  27     Method ...\Result::key() should return string but return statement is missing.
  32     Method ...\Result::status() should return string but return statement is missing.
  37     Method ...\Result::message() should return string but return statement is missing.
  42     Method ...\Result::weight() should return int but return statement is missing.
  47     Method ...\Result::label() should return string but return statement is missing.
  52     Method ...\Result::counts() should return bool but return statement is missing.
  57     Method ...\Result::isPassed() should return bool but return statement is missing.
 ------ ---------------------------------------------------------------------------

defaultAnalysisParser: CachedParser(originalParser: pathRoutingParser)