phpstan-strict-rules

Extra strict and opinionated rules for PHPStan

PHPStan focuses on finding bugs in your code. But in PHP there's a lot of leeway in how stuff can be written. This repository contains additional rules that revolve around strictly and strongly typed code with no loose casting for those who want additional safety in extremely defensive programming:

• in_array (3rd parameter)
• array_search (3rd parameter)
• array_keys (3rd parameter; only if the 2nd parameter $search_value is provided)
• base64_decode (2nd parameter). | | overwriteVariablesWithLoop | * Disallow overwriting variables with foreach key and value variables.
• Disallow overwriting variables with for loop initial assignment. | | switchConditionsMatchingType | Types in switch condition and case value must match. PHP compares them loosely by default and that can lead to unexpected results. | | dynamicCallOnStaticMethod | Check that statically declared methods are called statically. | | disallowedEmpty | Disallow empty() - it's a very loose comparison (see manual), it's recommended to use more strict one. | | disallowedLooseComparison | Disallow loose comparison via == and !=. | | disallowedShortTernary | Disallow short ternary operator (?:) - implies weak comparison, it's recommended to use null coalesce operator (??) or ternary operator with strict condition. | | noVariableVariables | Disallow variable variables ($$foo, $this->$method() etc.). | | checkAlwaysTrueInstanceof, checkAlwaysTrueCheckTypeFunctionCall, checkAlwaysTrueStrictComparison | Always true instanceof, type-checking is_* functions and strict comparisons ===/!==. These checks can be turned off by setting checkAlwaysTrueInstanceof, checkAlwaysTrueCheckTypeFunctionCall and checkAlwaysTrueStrictComparison to false. | | | Correct case for referenced and called function names. |

| matchingInheritedMethodNames | Correct case for inherited and implemented method names. | | | Contravariance for parameter types and covariance for return types in inherited methods (also known as Liskov substitution principle - LSP).| | | Check LSP even for static methods. | | requireParentConstructorCall | Require calling parent constructor. | | disallowedBacktick | Disallow usage of backtick operator ($ls = `ls -la`). | | disallowedImplicitArrayCreation | Disallow implicit array creation through $var[] = when the variable does not exist yet. | | strictArrayFilter | Require array_filter() to have a callback parameter to avoid loose comparison semantics. | | illegalConstructorMethodCall | Disallow calling __construct() on an existing object or as a static call outside of parent constructor. | | closureUsesThis | Closure should use $this directly instead of using $this variable indirectly. |

Additional rules are coming in subsequent releases!

Installation

To use this extension, require it in Composer:

composer require --dev phpstan/phpstan-strict-rules

If you also install phpstan/extension-installer then you're all set!

Manual installation

If you don't want to use phpstan/extension-installer, include rules.neon in your project's PHPStan config:

includes:
    - vendor/phpstan/phpstan-strict-rules/rules.neon

Disabling rules

You can disable rules using configuration parameters:

…

Aside from introducing new custom rules, phpstan-strict-rules also change the default values of some configuration parameters that are present in PHPStan itself. These parameters are documented on phpstan.org.

Enabling rules one-by-one

If you don't want to start using all the available strict rules at once but only one or two, you can!

You can disable all rules from the included rules.neon with:

parameters:
	strictRules:
		allRules: false

Then you can re-enable individual rules with configuration parameters:

parameters:
	strictRules:
		allRules: false
		booleansInConditions: true

Even with strictRules.allRules set to false, part of this package is still in effect. That's because phpstan-strict-rules also change the default values of some configuration parameters that are present in PHPStan itself. These parameters are documented on phpstan.org.