Wrong definition of Query, Key, Value matrices? They shouldn't have bias=True
Author: LeoPerelliCreated Dec 3, 2022Updated May 6, 2024
Hi @karpathy and thanks for your work!
I noticed that in the definition of the self-attention matrices you use a Linear layer which has bias, while I don't expect it to be there as we only want the matrix. I am talking about:
self.c_attn = nn.Linear(config.n_embd, 3 * config.n_embd)
Is this wanted or is it just a small bug? Thanks!
Source: karpathy/minGPT