#3727·peft

target_parameters docs: broken example and a wrong regex claim

Author: JiangLLMCreated Sep 12, 2026Updated Sep 16, 2026

Three small problems in the target_parameters documentation. Per the contribution guideline I would like a maintainer's approval before I send a PR. This is related to but distinct from #3721, which fixes grammar in the same area.

1. The example is not valid Python. A closing quote is missing:

python
target_parameters=['feed_forward.experts.gate_up_proj', 'feed_forward.experts.down_proj]

Anyone who copies it gets a SyntaxError. The same string appears in three places: the class docstring (src/peft/tuners/lora/config.py:615), the field help text (line 952), and the rendered API page (docs/source/package_reference/lora.md, "Targeting nn.Parameter directly").

2. The field help text claims regex support that does not exist. Line 945 says:

List of parameter names or regex expression of the parameter names to replace with LoRA.

The docstring a few lines above states that regex "is not implemented yet", and the matcher in tuners_utils.py only does exact and suffix matching. The "or regex expression" part should go.

3. One garbled sentence in the docstring. Line 608 reads "List of parameter names of the parameter names to replace with LoRA."

I would pool the three into one small PR — two files, about six lines — the same shape as #3562 / #3568. May I go ahead?