Comment describing SetVLOGLevel is not accurate
Author: hari90Created Sep 7, 2022Updated Jun 22, 2024
LabelsPR welcome
Currently the comment states the following:
// NOTE: To change the log level for VLOG(_IS_ON) sites
// that have already executed after/during InitGoogleLogging,
// one needs to supply the exact --vmodule pattern that applied to them.
// (If no --vmodule pattern applied to them
// the value of FLAGS_v will continue to control them.)But https://github.com/google/glog/pull/650 added support for updating vmodule levels after vmodule level has been cached.
The comment should be
// NOTE: To change the log level for VLOG(_IS_ON) sites
// that matched a prior --vmodule pattern then the exact pattern has to be supplied again.
// (If no --vmodule pattern applied to them before then the first matching pattern will start to control them.)Source: google/glog