The way the planet panel pausing sounds is not great
Is there an existing issue for this?
- Derpy told me he searched the existing issues
Describe the bug
The planet panel currently pauses sounds, for example, effects playing in space when you land. Those sounds then resume when you take off. But you're not taking off back into the same circumstances as you landed from. I don't think it makes much sense to pause sounds on landing and then resume them on taking off.
Steps to Reproduce
- Launch the game.
- Go to space.
- Get some sounds playing. Going to a place with lots of ships is good. Engine sounds, weapon sounds, whatever.
- Land.
- Take off. Despite the old ships being gone and new ships doing different things being present, the ends of the old sounds will be played.
Expected Behavior
Sounds from before landing should not be played after taking off.
Screenshots
N/A
Save File
No.
Error Log
Nothing relevant.
Operating System
Anywhere the game runs. (I use Windows 10 Pro 22H2)
Game Source
Steam
Game Version
0.11.0
Additional Information
#11866 and #11879 sought to fix this by not pausing when landing, but introduced a different issue where, following the creation of a new pilot, sound pausing would not work correctly or at all until the game was restarted, and so those changes were reverted by #12201.
Source: endless-sky/endless-sky