Request release including #580 (modal prop forwarded to Radix Dialog)
Author: danylkodCreated May 5, 2026Updated May 16, 2026
PR #580 ("fix: Added missing modal prop to Drawer.Root") was merged on 2025-07-25 but has not been released — the latest tag is v1.1.2 (2024-12-14).
The merged change fixes a real bug for any consumer using modal={false}:
- Vaul's
modal={false}is silently overridden because it never reaches the underlying RadixDialog.Root(which then defaults tomodal=true). - This makes the FocusScope trap focus even when the consumer explicitly opted out, conflicting with any other focus-management library on the page (e.g.
focus-trap-reactfrom another modal). - I reproduced this as a "Maximum call stack size exceeded" loop between
focus-trap'scheckFocusIn/tryFocusand RadixFocusScope'shandleFocusOut2/focus.
Related:
- PR #580 — merged fix (https://github.com/emilkowalski/vaul/pull/580)
- Issue #497 — symptom (https://github.com/emilkowalski/vaul/issues/497)
- Issues #492, #509, #517, #519 also reference the same
modal={false}gap.
Following the precedent of #593, opening this to request a release that includes #580. Thanks!
Source: emilkowalski/vaul