[Bug] VFN can't state sync from other VFNs if it receives 3 inbound connections
Author: mgorvenCreated Apr 22, 2021Updated Feb 16, 2023
Labelsbug
Bug
VFNs connect to 3 other VFNs in order to state-sync if it loses its connection to its own validator. However it will only state sync on an outbound connection. If the VFN happens to receive 3 inbound connections from other VFNs it won't make additional outbound connections. In this case if it loses connectivity to its own validator it won't state sync.
Detected on big testnet when val0 validator was stopped to test restore. The val0 vfn stopped syncing.
Expected Behavior
VFN should be able to state sync regardless of connection directions.
System information
Please complete the following information:
- 3f7de435
Source: diem/diem