release branch rules for required status checks: build-artifacts vs. publish-artifacts
Our branch protection rules for release branches use release-* as the pattern, which matches all release branches. This rule currently has a required status check for publish-artifacts.
However, this CI step changed its name for v2.2 with the migration to nix, it's now called build-artifacts:
https://github.com/crossplane/crossplane/blob/release-2.2/.github/workflows/ci.yml#L205
This means that release branch PRs in v2.2 will fail to meet the required status check because they are reporting the results for build-artifacts while the branch rules are waiting for publish-artifacts. Previous release branches are unaffected because they are using the old step name.
A few options here:
- We could make different release branch rules, but that seems like a pain to maintain over time.
- Update the required status check to the more recent
build-artifacts, which will cause older releases to fail this check until they are no longer supported. - Change the name of the step in
mainandrelease-2.2back to the originalbuild-artifactsname - not sure of the impact/dependencies of this change.
If we don't pick a solution then at least this issue serves as a reminder/documentation we can point out when a release branch PR hits this issue and we bypass the required status check
Source: crossplane/crossplane