Better error message to know if browsh or firefox is segfaulting.

Author: gl-yziquelCreated Jun 17, 2024Updated Feb 17, 2026

Hello.

I build browsh from source and git HEAD. And also firefox. So it's not entirely surprising that I get segfaults. However, I here wish to complain about the error message system. I get:

bash

panic: runtime error: invalid memory address or nil pointer dereference
                                                                       [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x4cc50e]

                                                                                                                                             goroutine 9 [running]:
                                                                                                                                                                   os.(*Process).signal(0x4?, {0x968268?, 0xb75058?})
                                                                                                                                                                                                                        /home/mini-me/.goenv/v


ni-me/.goenv/versions/1.22.3/src/os/exec.go:140
                                               os.(*Process).kill(...)
                                                                        /home/mini-me/.goenv/versions/1.22.3/src/os/exec_posix.go:67
                                                                                                                                    os.(*Process).Kill(...)
                                                                                                                                                                /home/mini-me/.goenv/versions/1.22.3/src/os/exec.go:125
                                                                                                                                                                                                                       github.com/browsh-org/b

ard/hephaestus/browsh-master/interfacer/src/browsh/firefox.go:93 +0x5fa
                                                                       created by github.com/browsh-org/browsh/interfacer/src/browsh.setupFirefox in goroutine 1
                                                                                                                                                                        /home/mini-me/home/backyard/hephaestus/browsh-master/interfacer/src/br

So. 1. The layout is problematic. 2. It's really hard to tell, at first glance whether it is browsh or firefox that is segfaulting.

Could error handling and reporting be improved ?

Source: browsh-org/browsh

View original on GitHub View discussion on GitHub