Wrong doc and function signature for 8-bit optim
Author: gau-nernstCreated Jun 30, 2024Updated Aug 28, 2026
LabelsDocumentationContributions WelcomeOptimizers
System Info
NA
Reproduction
Argument optim_bits and amsgrad is not used for 8-bit Adam
The document for optim_bits is also wrong in this case, because we are using 8 bits here.
I'm thinking of 2 ways to solve this:
- Remove
optim_bitsandamsgradarguments (actually even 32-bit Adam also doesn't useamsgradargument) - If we want to keep the function signature the same, there should be a check that
optim_bits == 8andamsgrad == False
Expected behavior
NA
Source: bitsandbytes-foundation/bitsandbytes