#4639·sails

Find, Destroy or Update methods ignore undefined type attributes

Author: JosebasebaCreated Jul 14, 2017Updated Oct 3, 2025
Labelsorm

Waterline version: 0.13.0-rc11 Node version: 4.5 NPM version: 2.15.9 Operating system: MacOs


Hi guys, I found an issue that I'm not sure if it's a bug or something that you have considered. If you do something like this:

javascript
User.update({id: undefined}, {name: 'joe'}).exec()

This is gonna update ALL the users in the database, because the mongo query is gonna be something like this {}. The same thing happens with find/destroy methods.

So imagine that in your code you don't realize data X value is undefined and you lauch a destroy against it, you'll end up dropping all the collection with no clue about what just happened.

Thanks for your time.