SSR not waiting for queries to resolve

Author: klaaz0rCreated Nov 10, 2019Updated Jul 18, 2020

Labelsreproduction-needed

When running @apollo/client on the server the queries are not resolved before rendering static.

When checking out getMarkupFromTree I noticed that the following code returns false:

    return renderPromises.hasPromises()
      ? renderPromises.consumeAndAwaitPromises().then(process)
      : html;

So non of the queries (using hooks) are ending up in renderPromises. Having hooked in apollo-logger I did notice that the queries after the request get resolved!

Intended outcome: Complete the queries correctly for server side rendering.

Version

    "@apollo/client": "^3.0.0-beta.6",
    "@apollo/react-ssr": "^3.1.3",

  System:
    OS: macOS Mojave 10.14.6
  Binaries:
    Node: 12.13.0 - ~/.nvm/versions/node/v12.13.0/bin/node
    Yarn: 1.19.1 - ~/.nvm/versions/node/v12.13.0/bin/yarn
    npm: 6.12.0 - ~/.nvm/versions/node/v12.13.0/bin/npm
  Browsers:
    Chrome: 78.0.3904.97
    Safari: 13.0.3

Source: apollographql/react-apollo

View original on GitHub View discussion on GitHub